Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please update modify-babel-preset to 3.1.0 #18

Closed
thisconnect opened this issue Oct 5, 2016 · 6 comments
Closed

please update modify-babel-preset to 3.1.0 #18

thisconnect opened this issue Oct 5, 2016 · 6 comments

Comments

@thisconnect
Copy link

https://github.com/developit/modify-babel-preset/releases

https://david-dm.org/rollup/babel-preset-es2015-rollup

@sorgloomer
Copy link

Unfortunately it seems this repo isn't maintained anymore. But the es2015 preset allows switching off module transpilation, so this babel config should be just fine:

 {
  "presets": [
    ["es2015", { "modules": false }]
  ],
  "plugins": [
    "external-helpers"
  ]
}

@thisconnect
Copy link
Author

Oh thanks. I guess I try Bublé, I thought that it wouldn't support JSX (by reading https://www.npmjs.com/package/rollup-plugin-buble and https://www.npmjs.com/package/buble)

But there is a JSX section https://buble.surge.sh/guide/#jsx

Else I try your suggestion. Thanks @sorgloomer

@travi
Copy link

travi commented Dec 12, 2016

with the latest babel release, this is a bigger problem. seeing that it is unlikely to be resolved soon, i will update to use babel-preset-es2015 directly, as suggested above, but the convenience of this preset was nice.

@Rich-Harris
Copy link
Contributor

I've removed modify-babel-preset in version 3 (it was causing problems in npm2) so I'll close this issue.

@travi
Copy link

travi commented Dec 13, 2016

thanks for getting this rolled out. it seems to have resolved the issue that i was seeing

@lzxb
Copy link

lzxb commented Dec 15, 2016

ok,Problem has been solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants