[@rollup/plugin-node-resolve] Cannot read property 'custom' of undefined

[dstaley]

• Rollup Plugin Name: @rollup/plugin-node-resolve
• Rollup Plugin Version: 13.0.6
• Rollup Version: 2.58.0
• Operating System (or Browser): Linux
• Node Version: v12.22.6
• Link to reproduction (⚠️ read below): https://replit.com/@dstaley/rollup-plugin-repro-1#rollup.config.js

Expected Behavior

Bundle is created (or at least an error about TypeScript).

Actual Behavior

./test/index_test.ts → dist/test-suite.js...
[!] (plugin node-resolve) TypeError: Cannot read property 'custom' of undefined
TypeError: Cannot read property 'custom' of undefined
    at Object.resolveId (/home/runner/rollup-plugin-repro-1/node_modules/@rollup/plugin-node-resolve/dist/cjs/index.js:1162:83)
    at /home/runner/rollup-plugin-repro-1/node_modules/rollup/dist/rollup.js:12899:25

Additional Information

I ran into this issue while trying to reproduce an issue with the TypeScript plugin.

[tjenkinson]

@dstaley I think you're rollup version in the description is incorrect? In the repl you have ^1.27.14. 2.58.0 works fine

[shellscape]

@rollup/plugin-node-resolve has a peer dep of ^2 as well, so this wouldn't actually be a bug, but a violation of peerDep requirements, which we're not responsible for supporting. see:

plugins/packages/node-resolve/package.json

Line 54 in 6eb6616

"rollup": "^2.42.0"

[tjenkinson]

Agree. The rollup peer dependency requirement of the resolve plugin is ^2.42.0, which works fine given custom was added in 2.29.0, so closing this.

[dstaley]

Sorry about that! The Replit UI confusingly lists the latest version of installed packages in their UI versus the actually installed version.

[0xdevalias]

Should the README be updated to align with this then? As currently it says:

This plugin requires an LTS Node version (v8.0.0+) and Rollup v1.20.0+.

Yet package.json suggests that it actually requires Node >= 10.0.0 and peerDependencies of "rollup": "^2.42.0"

Looking at the CHANGELOG, i'm not sure this was marked as a breaking change anywhere either was it?

---

Edit: I've opened an issue to track this specficially:

• [@rollup/plugin-node-resolve] Fix required versions of Node/Rollup in README + include these breaking changes in CHANGELOG #1222