(createFilter): should it recognize *.ext as matching files at root path?

[gyhyfj]

Currently,
if the include field is ['123.ts'], file named 123.ts at root path of project will be included.
but if the include field is ['*.ts'], file named 123.ts at root path of project will not be included.

Should I modify code in packages/pluginutils/src/createFilter.ts like this ?

  function getMatcherString(id: string, resolutionBase: string | false | null | undefined) {
-   if (resolutionBase === false || isAbsolute(id) || id.startsWith('*')) {
+   if (resolutionBase === false || isAbsolute(id) || id.startsWith('**')) {

Sorry I can't make a pr cause test script can't run on my pc.

[TrickyPi]

  function getMatcherString(id: string, resolutionBase: string | false | null | undefined) {
-   if (resolutionBase === false || isAbsolute(id) || id.startsWith('*')) {
+   if (resolutionBase === false || isAbsolute(id) || id.startsWith('**')) {

Hmm, That looks good to me.

Sorry I can't make a pr cause test script can't run on my pc.

I want to know what error was reported?

[shellscape]

Our issue template is very clear. We're closing this for not including required information.

[gyhyfj]

Sorry I can't make a pr cause test script can't run on my pc.

I want to know what error was reported?

I pull this repo and then run pnpm i, it throw error in terminal:

PS D:\GitRepo\plugins> pnpm i
Scope: all 32 workspace projects
Lockfile is up to date, resolution step is skipped
Already up to date
packages/auto-install prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 39ms at D:\GitRepo\plugins\packages\auto-install
packages/buble prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 44ms at D:\GitRepo\plugins\packages\buble
packages/alias prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 40ms at D:\GitRepo\plugins\packages\alias
 ELIFECYCLE  Command failed with exit code 1.
packages/commonjs prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 31ms at D:\GitRepo\plugins\packages\commonjs
packages/esm-shim prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 26ms at D:\GitRepo\plugins\packages\esm-shim
packages/dsv prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 28ms at D:\GitRepo\plugins\packages\dsv
packages/graphql prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 23ms at D:\GitRepo\plugins\packages\graphql
packages/eslint prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 43ms at D:\GitRepo\plugins\packages\eslint
packages/image prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 35ms at D:\GitRepo\plugins\packages\image
packages/json prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 27ms at D:\GitRepo\plugins\packages\json
packages/inject prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 20ms at D:\GitRepo\plugins\packages\inject
packages/multi-entry prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 24ms at D:\GitRepo\plugins\packages\multi-entry
packages/legacy prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 28ms at D:\GitRepo\plugins\packages\legacy
packages/replace prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 25ms at D:\GitRepo\plugins\packages\replace
packages/run prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 29ms at D:\GitRepo\plugins\packages\run
packages/node-resolve prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 39ms at D:\GitRepo\plugins\packages\node-resolve
packages/pluginutils prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 33ms at D:\GitRepo\plugins\packages\pluginutils 
packages/sucrase prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 35ms at D:\GitRepo\plugins\packages\sucrase
packages/swc prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 31ms at D:\GitRepo\plugins\packages\swc
packages/terser prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 30ms at D:\GitRepo\plugins\packages\terser
packages/typescript prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 23ms at D:\GitRepo\plugins\packages\typescript
packages/url prepare$ if [ ! -d 'dist' ]; then pnpm build; fi
│ ��ʱ��Ӧ�� !��
└─ Failed in 54ms at D:\GitRepo\plugins\packages\url

My system info is:

- Operating System: Windows_NT
- Node Version:     v18.16.0
- Package Manager:  pnpm@8.6.7

And I dont konw how to resolve encode error...
Could you please teach me how to deal with it 🙏

[TrickyPi]

I also ran into this problem on my Windows 10. For encoding errors, I don't know the reason, but you can use node -e \"fs.existsSync('./dist') || process.exit(1)\" || pnpm build(code from this PR #1530) instead of current command in the prepare script to fix this problem. After doing this, then you will see a typescript error, It is a soft link problem, I guess using New-Item to recreate a soft link could fix it (I have not verified it), but it will mess up the git. So I recommend using WSL on Windows for fixing this problem, which I have verified.