Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-install yarn tests #69

Closed
shellscape opened this issue Dec 2, 2019 · 2 comments · Fixed by #147
Closed

auto-install yarn tests #69

shellscape opened this issue Dec 2, 2019 · 2 comments · Fixed by #147

Comments

@shellscape
Copy link
Collaborator

  • Rollup Plugin Name: auto-install
  • Rollup Plugin Version: latest

Expected Behavior / Situation

I'd really enjoy it if the tests passed consistently. I frequently have to rerun the Circle CI workflows because of failed yarn tests.

Actual Behavior / Situation

☝️ same same

Modification Proposal

I'd like to nuke the yarn test that is failing intermittently. If someone can spot a way to get it working 100% of the time, I'm all for it.

Thoughts?

/cc @rollup/plugin-contributors @rollup/plugin-maintainers

@Andarist
Copy link
Member

Andarist commented Dec 3, 2019

While mocking is often not the right answer it seems that it might be here. We don't actually care how yarn (or any other package manager) installs stuff (what artifacts does it leave behind) - we could only check if it has been invoked correctly and trust it to do its job fine when invoked for real.

@shellscape
Copy link
Collaborator Author

That's very apt, and sounds like the right way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants