Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[node-resolve] package.json "browser" paths are incorrectly resolved for sub-paths #919

Closed
eemeli opened this issue Jul 1, 2021 · 1 comment
Closed

[node-resolve] package.json "browser" paths are incorrectly resolved for sub-paths #919

eemeli opened this issue Jul 1, 2021 · 1 comment

Comments

@eemeli
Copy link
Contributor

eemeli commented Jul 1, 2021

Expected Behavior

Build should succeed.

Actual Behavior

Build fails with a circular dependency:

node_modules/yaml/browser/index.js -> node_modules/yaml/browser/index.js

This is due to the browser import path for "./dist/index.js" being incorrectly applied when used in the browser/ sub-path of the yaml package.

Additional Information

Originally reported by @jdesrosiers as eemeli/yaml#291, see there for some initial debugging.

I'll work on a PR potentially fixing this.
@eemeli eemeli mentioned this issue Jul 1, 2021
Merged
9 tasks
@eemeli eemeli mentioned this issue Jul 17, 2021
Closed
@guybedford
Copy link
Contributor

Fixed in #920.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guybedford @eemeli