Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Replace use left node indexes when producing default export #120

Merged
merged 1 commit into from Sep 23, 2016

Conversation

btd
Copy link
Contributor

@btd btd commented Sep 23, 2016

Basically you can try to use such file to get error:

module.exports = (42);

It is compiled to:

var index = 42);
// etc

Copy link
Contributor

@Victorystick Victorystick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, and thanks a lot for the patch!

@Victorystick Victorystick merged commit 0399aad into rollup:master Sep 23, 2016
Victorystick added a commit that referenced this pull request Sep 25, 2016
@btd
Copy link
Contributor Author

btd commented Sep 28, 2016

@Victorystick @Rich-Harris sry for noise, could i get this published?

@Victorystick
Copy link
Contributor

I'm afraid I don't have NPM publish access. @Rich-Harris or @TrySound, do you mind?

@Rich-Harris
Copy link
Contributor

hey – sorry, you should have access now @Victorystick

@Victorystick
Copy link
Contributor

Published as 5.0.5.

@snuggs
Copy link

snuggs commented Oct 12, 2016

^^^^ Thanks for this. Ran into the problem before. Left it alone. 🙏 @Rich-Harris @Victorystick

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants