Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Plugin ignores rollup's globals option #68

Closed
wearhere opened this issue Dec 22, 2016 · 1 comment
Closed

Plugin ignores rollup's globals option #68

wearhere opened this issue Dec 22, 2016 · 1 comment

Comments

@wearhere
Copy link

wearhere commented Dec 22, 2016

This plugin attempts to resolve modules marked as globals, resulting in this error being thrown. This can be worked around by duplicating the global IDs in the skip list passed to this plugin, but shouldn't that be unnecessary—shouldn't this plugin automatically skip the globals?

Here is a Rollup configuration that reproduces this issue if you uncomment this line.

If it's not possible to read Rollup's globals option due to a limitation of Rollup's plugin API, lemme know and I'll file an issue against the main repo.

@wearhere
Copy link
Author

wearhere commented Jan 2, 2017

Ok per @Rich-Harris's comment here, this plugin will automatically skip modules marked as external, that's the option to use. https://github.com/wearhere/rollup-plugin-node-resolve-globals/blob/master/rollup.config.js has been updated accordingly to demonstrate.

@wearhere wearhere closed this as completed Jan 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant