Add requirements.txt to sdist, remove README.md from data_files #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rom1504#47. - `requirements.txt` being missing from the source tarball meant that this package was only possible to install from the wheel, not from the sdist; one can reproduce the problem by using `--no-binary :all:` as an argument to `pip`. - Adding `README.md` to `data_files` meant that it was installed into site-packages instead of only being added to the source tarball; being at the root, it conflicted with any _other_ Python package trying to install a README.md when using a package manager that tracks such conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47.
requirements.txtbeing missing from the source tarball meant that this package was only possible to install from the wheel, not from the sdist; one can reproduce the problem by using--no-binary :all:as an argument topip.README.mdtodata_filesmeant that it was installed into site-packages instead of only being added to the source tarball; being at the root, it conflicted with any other Python package trying to install a README.md when using a package manager that tracks such conflicts.