Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add list of int, float feature in TFRecordSampleWriter #217

Merged
merged 4 commits into from Nov 15, 2022

Conversation

justHungryMan
Copy link
Contributor

@justHungryMan justHungryMan commented Nov 11, 2022

We use list of int, list of float attribute in coyo-labeled-300m dataset. (It will be released soon)
To create a dataset using img2dataset in tfrecord, we need to add above features.

@rom1504
Copy link
Owner

rom1504 commented Nov 11, 2022

Can you please run make lint to fix the lint ?

@rom1504
Copy link
Owner

rom1504 commented Nov 11, 2022

Thanks,
Could we also support list of bytes ?
I need that feature for laion translated

Also it would be great to add a few test samples with additional columns being list of x in the test folder and use them there https://github.com/rom1504/img2dataset/blob/main/tests/test_writer.py to make sure it works and keeps working

@justHungryMan
Copy link
Contributor Author

justHungryMan commented Nov 11, 2022

@rom1504 Ok, it's good idea.
And I tried linting with black, but other parts that I didn't change were linted also. Am I using it wrong?

@rom1504
Copy link
Owner

rom1504 commented Nov 11, 2022

Yeah create a venv and do make install-dev

You probably have the wrong version of black

@justHungryMan
Copy link
Contributor Author

I just added dummy sample in test_writer.py.

@rom1504
Copy link
Owner

rom1504 commented Nov 15, 2022

thank you, looking good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants