Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default tolerance value not matching comments #2

Closed
arurke opened this issue May 18, 2020 · 2 comments
Closed

Default tolerance value not matching comments #2

arurke opened this issue May 18, 2020 · 2 comments

Comments

@arurke
Copy link
Contributor

arurke commented May 18, 2020

The comments for default tolerance value says consistently 1 %, while code is using both 5 % and 1%, see e.g. https://github.com/TriScale-Anon/triscale/blob/9627caa7a5e6ec32551c38335fde881fe9530134/triscale.py#L516
@TriScale-Anon
Copy link
Collaborator

Fixed! Thanks :-)

@arurke
Copy link
Contributor Author

arurke commented Oct 29, 2020

@TriScale-Anon The fix for this issue reverted the change from #1.

See a3300f5#diff-5d6a342b320c918c6a910ae0e1f63b968f1bea8013188186b09357d9bbe4f113L837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arurke @TriScale-Anon