Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin works after UglifyJsPlugin #3

Open
elad-maimon opened this issue Jul 21, 2016 · 1 comment
Open

Plugin works after UglifyJsPlugin #3

elad-maimon opened this issue Jul 21, 2016 · 1 comment

Comments

@elad-maimon
Copy link

Hi again,

I'm using the WebpackRtlPlugin together with UglifyJsPlugin and in my code I have directives for rtlcss like: /* rtl:begin:ignore */.

The problem is the uglifier works before the WebpackRtlPlugin and removes these comments.

I'm not sure if this is an issue here or in UglifyjsPlugin since I've tried to use the options.comments to tell the uglifier to ignore these comments but it didn't work.. but anyway it seems to me that the .rtl.css should be generated before the uglifier and be added to the asset list.

@romainberger
Copy link
Owner

This issue should be fixed with #5 (published in version 1.5.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants