Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update precommit hooks & CI #673

Merged
merged 5 commits into from Sep 16, 2023
Merged

Conversation

gsakkis
Copy link
Contributor

@gsakkis gsakkis commented Aug 23, 2023

  • Update precommit hooks
  • Replace lint and mypy CI workflows with a precommit task in the test workflow
  • Sort imports with ruff

@roman-right
Copy link
Member

Hi @gsakkis,
Thank you for the PR.
I think having a pre-commit check instead of separate MyPy and lint checks is good. However, it's better to have it in a separate GH action. It doesn't depend on Python or MongoDB versions, but it will run with each of them.

As often happens with formatter PRs, there are many conflicts. Could you please resolve them? Once you've done so, ping me on Discord before I merge anything else; this will help avoid creating more conflicts.

@gsakkis
Copy link
Contributor Author

gsakkis commented Sep 15, 2023

Hi @roman-right, I updated the PR and moved the precommit to a separate job. Thanks!

@roman-right roman-right merged commit 60dc39c into BeanieODM:main Sep 16, 2023
21 checks passed
@roman-right
Copy link
Member

Thank you very much for your PR. Merged

@gsakkis gsakkis deleted the update-precommit-ci branch September 17, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants