Fix aggregations with text queries #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MrEarle , |
|
Oh, you're right! I'll fix it as soon as I have some time for it 馃憣馃徏 |
MrEarle
force-pushed
the
fix/aggregations-with-text-queries
branch
from
92181ee
to
5790630
Compare
|
Fixed the tests. I was using |
|
Awesome! I'll play with it tomorrow and merge. Thank you! |
roman-right
approved these changes
Oct 25, 2023
|
Good job! And I like how you avoided Python comparison operations, as they are overridden. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to fix the bug referred to in #606.
First time contributing here, so please let me know if I'm missing something or I'm not up to your standards 馃榿.