Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom bucket fields in time series #760

Merged
merged 2 commits into from Dec 3, 2023

Conversation

Luc1412
Copy link
Contributor

@Luc1412 Luc1412 commented Oct 29, 2023

This PR adds support for the custom bucket fields for time series introduced in MongoDB 6.3 https://www.mongodb.com/docs/manual/core/timeseries/timeseries-procedures/

@roman-right
Copy link
Member

Hi @Luc1412 ,
Thank you for the PR! Could you please check what MyPy doesn't like there?

@Luc1412
Copy link
Contributor Author

Luc1412 commented Nov 6, 2023

@roman-right Am not sure what's wrong. There isn't a type definition of that mentioned string

@roman-right
Copy link
Member

No problem, I'll check it this weekend and or will fix it or will ask mypy to ignore

@roman-right roman-right merged commit 2375991 into BeanieODM:main Dec 3, 2023
21 checks passed
@roman-right
Copy link
Member

Hi @Luc1412 ,
Thank you for the PR! Merged. Will be published soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants