Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support native reads and writes into S3 #10

Closed
romange opened this issue Aug 23, 2022 · 7 comments
Closed

support native reads and writes into S3 #10

romange opened this issue Aug 23, 2022 · 7 comments
Assignees

Comments

@romange
Copy link
Owner

romange commented Aug 23, 2022

we currently can read only from a local file system. It could be nice if we could read natively from s3.
Also we should consider to support https://github.com/minio/minio (could probably help with e2e tests locally as well).
(I am not sure what does it mean to support min.io since they should be compatible with S3 API)

we already have a POC code here: https://github.com/romange/gaia/tree/master/util/aws
but it will require changes to be adopted into helio - better abstractions, better reliability, no check-fails, use helio sockets etc.

@romange
Copy link
Owner Author

romange commented Sep 23, 2022

https://github.com/romange/gaia/blob/master/file/s3_file.h file can serve as an example of how it can be done

@romange
Copy link
Owner Author

romange commented Apr 30, 2023

Update: s3_demo works.
./s3_demo lists all buckets
./s3_demo --path s3://bucket/prefix will list files under the bucket
./s3_demo --cmd read s3://bucket/obj_path will output first K bytes of the file. If the bucket is located in a different region - error is returned.

@romange
Copy link
Owner Author

romange commented May 2, 2023

docker run --rm    -p 9000:9000    -p 9090:9090    --user $(id -u):$(id -g)    --name minio1    -e "MINIO_ROOT_USER=root"    -e "MINIO_ROOT_PASSWORD=12345678" -v ${HOME}/minio/config:/root/.minio   -v ${HOME}/minio/data:/data    quay.io/minio/minio server /data  --console-address ":9090"

and then export AWS_ACCESS_KEY_ID=root and export AWS_SECRET_ACCESS_KEY=12345678

@romange
Copy link
Owner Author

romange commented May 18, 2023

we do not get etag sometimes.

1.log

@andydunstall
Copy link
Collaborator

As agreed with Ari - assigning myself to work on cloud snapshots (added a separate 'cloud snapshots' project which breaks this issue up a bit)

@andydunstall andydunstall self-assigned this Sep 7, 2023
@romange
Copy link
Owner Author

romange commented Sep 7, 2023

Thanks Andy!
Please note this PR in progress - #133 which will remove icu/xml2 shared library dependencies from our binaries.

@andydunstall
Copy link
Collaborator

I think this can be closed now given cloud snapshots were added in last release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants