Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty ZoneId #52

Closed
PaulDaviesC opened this issue Mar 11, 2020 · 2 comments
Closed

Empty ZoneId #52

PaulDaviesC opened this issue Mar 11, 2020 · 2 comments

Comments

@PaulDaviesC
Copy link

Can there be a case where the ZoneId is returned empty by engine.query() for a valid latitude and longitude?

@RomanIakovlev
Copy link
Owner

In general, yes. When the library is initialized with a bounding box smaller than the whole world, all the valid coordinates outside of that bounding box will return the empty answer. When the library is initialized without specifying the bounding box (i.e. for the whole world), it might return the empty answer for some valid coordinates if and only if the source data (see https://github.com/evansiroky/timezone-boundary-builder) has gaps in its coverage at those coordinates.

I'm not sure if the source data covers the whole world without any gaps, but I think the answer is most probably 'yes'. If you must be absolutely sure, ask in the source data project.

@PaulDaviesC
Copy link
Author

Thanks @RomanIakovlev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants