Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#145: Migrate to JUnit 5. #159

Merged
merged 3 commits into from Jan 8, 2020
Merged

#145: Migrate to JUnit 5. #159

merged 3 commits into from Jan 8, 2020

Conversation

Wandmalfarbe
Copy link
Contributor

@Wandmalfarbe Wandmalfarbe commented Dec 22, 2019

Should close issue #145.

  • Migrated from JUnit 4.12 to JUnit 5.5.2 (Jupiter).
  • Use JUnit exception handling instead of BaseTest#getException()
  • Updated the Gradle version from 3.5-rc-2-all to 6.0.1-bin. Starting with version 4.6, Gradle provides native support for executing tests on the JUnit Platform.
  • Fixed Maven warnings for plugins without a version number.
  • Fixed Maven warning about platform dependent file encoding.

- Migrated from JUnit `4.12` to JUnit `5.5.2` (Jupiter).
- Use JUnit exception handling instead of `BaseTest#getException()`
- Updated the Gradle version from `3.5-rc-2-all` to `6.0.1-bin`. Starting with version 4.6, Gradle provides native support for executing tests on the JUnit Platform.
- Fixed Maven warnings for plugins without a version number.
- Fixed Maven warning about platform dependent file encoding.
@romankh3
Copy link
Owner

Thanks for your contribution, @Wandmalfarbe !
Something went wrong with your updates, as you can see, checks have not completed yet.
It must be fixed.

Best regards,
Roman.

@Wandmalfarbe
Copy link
Contributor Author

I can submit a new pull request if it helps?

@romankh3
Copy link
Owner

Yes, you can. Add a new commit with updates in your repository - it will automatically update this PR.

- Updated `gradle-wrapper.properties` with IntelliJ.
@romankh3
Copy link
Owner

I created a new Pull-Request to check. Removed codacy and coveralls checks. Nevertheless build and security is not working here... I don't know why.

@romankh3 romankh3 merged commit 12195c5 into romankh3:master Jan 8, 2020
@romankh3
Copy link
Owner

romankh3 commented Jan 8, 2020

@Wandmalfarbe thanks for your contributions.
I'll take care of all the checks, later.

@Wandmalfarbe
Copy link
Contributor Author

Glad I could help!

@romankh3 romankh3 added this to In progress in 4.0.1 via automation Jan 11, 2020
@romankh3 romankh3 moved this from In progress to Done in 4.0.1 Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
4.0.1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants