New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QUESTION] getDifferencePercent meaning #189
Comments
Hello @dmiroshnyk, Best regards, |
`
|
Please, provide |
It provides basic properties setup
} |
Hi @dmiroshnyk, I found what you're looking for. To understand how it works, you can see this logic
For now, this logic is using in case, when we have SIZE_MISMATCH, that's why for valid image sizes this is not counting. From my perspective, this looks like a bug. Do you really need it? This is was added and maintained by the community and I haven't paid enough attention on it. |
Hi @romankh3 , Thanks for digging into it! In case it's easy to fix - yes, I will be very appreciated to have a new version with fix - this allows my tests to be more manageable. Could you please share the estimated time to fix if possible? This allows me to understand my plans. I also have several questions regarding this:
|
It's not so hard, but I don't have enough time for it. As you can see, I answered after week.
|
Hope you'll have time for this one day :)
|
Hi @dmiroshnyk,
To summarise, if you can - you can fix this bug with |
added it to |
Hi @romankh3 !
Could you please clarify how the differencePercent is calculated?
I compare these 2 images:
and
and got the result:
Then I trying to use something like:
return (imageComparisonResult.getDifferencePercent() <= diffPercentage)
I expected getDifferencePercent is calculated like total square of all difference rectangles vs image square, like:
Sum (S<i = 1..n> S) / S ~ 15% for my images.
But surprisingly I got 0.0! Could you please clarify where I'm wrong?
Thanks in advance!
The text was updated successfully, but these errors were encountered: