New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow program to run as a traditional CLI #23
Conversation
Parse CLI options to know whether the user wants to see the demo (default), or compare two images and see the result (or save the result image to a file).
That coverage decrease is pretty weird, given that almost the only thing I changed in |
Javadoc for public constructor (allows ImageComparison to be used as a library).
Oh wow, I made the code a bit worse and now Coveralls is happy :D |
Hello, @renatoathaydes. Good idea to do it. I think this updates should be described in README.md according to the updates with running an application. Coverage can be fixed if you create test with running |
The Coveralls report was green when I commented!! Looks like it changed later. |
Looks like coveralls is happy now. If you need any help I can make a Pull Request with the necessary changes. |
You've done good work. I will accept your changes and merge it into |
@renatoathaydes, I don't have enough time to do that and don't have an experience in publishing to Maven Central. |
Thanks.
Sure, but first you'll have to get a Sonatype account and Bintray account. The link I gave above explain how you do that. |
@renatoathaydes Hello. I did something, but I'm not sure that it's what you want. I added a barge to README.md and you can see it. Please, provide some feedback. P.S. I wrote you an email message. |
You're almost done. There's no uploaded files here: https://bintray.com/romankh3/image-comparison/image-comparison/V2.0#files You need to run |
In this PR, I 've added a simple
ArgsParser
class to allow user to pass in options to the program, so that they can compare two images from image files they pass in as arguments.The user can also give a file where the result should be saved to. Not providing an output file makes the program open the UI, as it does currently.
I also made the jar created by Gradle be runnable (by adding the
Main-Class
entry to the manifest), so now you can run the program withjava -jar image-comparison.jar
.