-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also export 1024px web version in the launcher icon generator #242
Conversation
Hi @romannurik, I would appreciate if you could review my pull request and consider publishing it, so others can benefit from it, as well. Thank you in advance. |
Hi there -- right now the tool is REALLY focused on Android + the Play Store. I recognize though that a lot of folks use it for things other than Android. I've been thinking about splitting out the launcher icon generator into a more general purpose branding generator (Android, iOS, Chrome, etc.) which would totally benefit from 1024px output, but no progress on that yet. |
@romannurik I would kindly ask you to overthink your decision. That the 1024px Version is useful to use for iOS icon creation was my primary intent, but it's not limited to that. All my changes do are exporting also a 1024px version of the created icon, there is no indication that it's meant to support iOS, nor is there any further processing on the file. In fact I classified the export as
No, we do not use your tool for iOS icon creation, but we are looking for consistency. If one cannot export a higher resolution of the icon than 512x512, the Launch Icon Generator is useless, when targeting more than one platform. You have no obligation to follow any iOS icon creation work-flows, but accepting this PR would enable your users to consider your tool for the Android part for initial icon creation when targeting both platforms, because the exported 1024px version can be used on other tools to make an iOS version icon. This process would be separate and wouldn't have any connection to Android Asset Studio, even if this PR was accepted and its changes were published. |
I agree with most if not all of your points. The problem is merging this PR feels like a bandaid solution, where I'd really much rather do something more well-considered, as part of a more generic generator. Let me think on it -- reopening for now. |
@romannurik Thank you, and I totally agree that a more generic generator (that exports for more than one platform) would be superior, but simply exporting a 1024px version seems to be a good and fast trade-of, because there are good tools for iOS icon creation, but those tools lack the versatility of the Android launcher icon shapes that your wonderful tool provides. Generally, having larger versions of the made icon seems never wrong to me. Maybe it even makes sense to export 2k and 4k, but my primary focus was to address #159. |
Did some more thinking on this - let's pursue a 1024px output (and thank you for the PR). I want to play around with this locally before offering review + merging, but will reply back asap. |
OK took a look, going to (1) merge this in and (2) make some slight tweaks in a fast-follow. |
Hey @romannurik I've seen you provide a nice alternative now (IconKitchen) which is a neat project which has huge potential. Unfortunately, it is harder for me to use right now.
I would like to give so much more feedback, but I think this repo is the wrong place. Are you planning on providing the sources or at least a hub to allow suggestions? |
Since the maximum icon size for iOS icons is 1024px, it is useful to export an additional 1024px web version in the launcher icon generator, the 512px version will continue to be exported for backward compatibility.
The user can then proceed by feeding the raw 1024px icon into an iOS icon generator of his choice to get a streamlined experience.
Fixes #159