Only do a full update() from addArtwork() if something changed #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid doing a full update (and the subsequent notifyChange()) if nothing actually changed. This removes cases where there's just a single image and it is unconditionally changed every time onLoadRequested() is called, causing an infinite loading loop. When developers specifically call update(), we always call notifyChange() in case they are sorting by DATE_MODIFIED and want an updated list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid doing a full update (and the subsequent notifyChange()) if nothing actually changed. This removes cases where there's just a single image and it is unconditionally changed every time onLoadRequested() is called, causing an infinite loading loop.
When developers specifically call update(), we always call notifyChange() in case they are sorting by DATE_MODIFIED and want an updated list.
Fixes #559