Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goodreads isn't listing index results #3

Closed
seanap opened this issue Sep 19, 2020 · 2 comments
Closed

Goodreads isn't listing index results #3

seanap opened this issue Sep 19, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@seanap
Copy link

seanap commented Sep 19, 2020

I think the goodreads source is broken. Something seems to be going on with the Index section, it's not parsing the results. It looks like it is skipping to the last result and not presenting the options. I looked over the Title, URL, and Author sections and everything looks OK.

@romanoh romanoh added the bug Something isn't working label Sep 19, 2020
@romanoh
Copy link
Owner

romanoh commented Sep 19, 2020

@seanap yes there was something wrong in "the do While", they keep changing the html. I also made some other changes, although is is not finished yet.
thank you for noticed. i use it manly to improve my audiobooks (also with the other one to get author image and bio).

@cerinawithasea
Copy link

cerinawithasea commented Feb 22, 2024

I know this is closed but i have a goodreads source that was

created by FidoFuz

# 2021-02-27 Initial Release

2021-02-28 Miscellaneous Fixes

2023-02-27 Updated by SeaNap

2023-06-06 Updated by CerinawithaSea

I cant tell you what i did, I'm bipolar when i get hypo....i just do stuff
and maybe it's still broken i rarely use it, but i do get choices

####################################
# Mp3tag parsing for goodreads.com, created by FidoFuz
#
# 2021-02-27 Initial Release
# 2021-02-28 Miscellaneous Fixes
# 2023-02-27 Updated by SeaNap
# 2023-06-06 Updated by CerinawithaSea
#
# This file should be saved in your mp3tag sources folder: %AppData%\Roaming\Mp3tag\data\sources
#
###################################
 
[Name]=Goodreads
[BasedOn]=www.goodreads.com
[IndexUrl]=https://www.goodreads.com/search?utf8=%E2%9C%93&search_type=books&q=
[AlbumUrl]=https://www.goodreads.com
[WordSeperator]=+
[IndexFormat]=%Title%|%_url%|%Author%
[SearchBy]=%artist% $regexp(%album%,'[- ]+cd ?\d+$',,1)
[Encoding]=url-utf-8
 
[ParserScriptIndex]=...
# ###################################################################
#					I  N  D  E  X
# ###################################################################
#DebugWriteInput "C:\Users\%user%\Desktop\goodreads\search.html"
#Debug "ON" "C:\Users\%user%\Desktop\goodreads\search_debug.txt"
 
findline "<meta content='Search results" 1 1
unspace
if "<meta"
	findline "<tr itemscope itemtype=\"http://schema.org/Book\">" 1 1
	unspace
	do
		#  Title
		findline "<a title=\""
		findinline "<a title=\""
		sayuntil "\""
		say "|"
 
		# Url
		findinline "href=\""	
		sayuntil "\">"
		say "|"
 
		# Author
		findline "class=\"authorName\""
		joinuntil "</a>"
		findinline "\"name\">"
		sayuntil "<"
 
		saynewline
		findline "<tr itemscope itemtype=\"http://schema.org/Book\">" 1 1
		unspace
	while "<tr" 20
else
	gotoline 1
	# redirected straight to the page instead of a search page, just pass it to the Album Parser
	# usually when an ISDB or ASIN is provided as the search
	say "|"
	sayoutput "currenturl"
	say "|"
	saynewline
endif
 
[ParserScriptAlbum]=...
# ###################################################################
#					A  L  B  U  M
# ###################################################################
#DebugWriteInput "C:\Users\%user%\Desktop\goodreads\detail.html"
#Debug "ON" "C:\Users\%user%\Desktop\goodreads\detail_debug.txt"
 
# Album
findline "type\":\"Book\",\"name\":\""
joinuntil "\",\"image\""
Replace "&apos;" "'"
findinline "type\":\"Book\",\"name\":\""
outputto "album"
sayuntil "\",\""
 
# Cover
findline "\",\"image\":\""
findinline "\",\"image\":\""
outputto "coverurl"
sayuntil "\",\""
 
# Author
findline "type\":\"Person\",\"name\":\""
findinline "type\":\"Person\",\"name\":\""
outputto "albumartist"
sayuntil "\",\""
 
# Summary
gotoline 1
findline "<span class=\"Formatted\">"
findinline "<span class=\"Formatted\">"
#regexpreplace "</?[^><]+>" ""
#replace "<br />" " "
outputto "comment"
sayuntil "</span>"
 
# Series
#findline "Series\",\"title\":\""
#findinline "Series\",\"title\":\""
#outputto "Series"
#sayuntil "\",\""
 
# Series-part
#findline "<!-- --> #"
#findinline "<!-- --> #"
#outputto "Series-part"
#sayuntil "<"
 
# Year
findline "publicationInfo\">"
findinline "publicationInfo\">"
findinline "<"
movechar -5
outputto "year"
sayuntil "<"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants