Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VGMDB - Can track names not be pulled from either the HTML or the JSON? #4

Closed
Tenome opened this issue Oct 11, 2020 · 7 comments
Closed
Labels
bug Something isn't working

Comments

@Tenome
Copy link

Tenome commented Oct 11, 2020

Hello, first time using your script (very useful!). I was just wondering because I never get any track names whenever I pull up the album in MP3Tag. Is it something on VGMDB's end that makes fetching the names difficult?

Thanks.

@romanoh
Copy link
Owner

romanoh commented Oct 11, 2020

Sometimes They change
the html so the scrape wont work, will try to fix it this week

@Tenome
Copy link
Author

Tenome commented Oct 11, 2020

Thanks!

@romanoh
Copy link
Owner

romanoh commented Oct 12, 2020

Have you tried the JSON version?, it works for me (except the artist, as i am waiting for the original author of the JSON to make the change).

imagem

@romanoh
Copy link
Owner

romanoh commented Oct 12, 2020

Please try the HTML let me now.

@romanoh romanoh added the bug Something isn't working label Oct 12, 2020
@Tenome
Copy link
Author

Tenome commented Oct 12, 2020

HTML seems to work now. JSON gives me blank results like before, but I can live with that if HTML works. Thanks!

https://puu.sh/GCgDj/89485857d6.png

@romanoh
Copy link
Owner

romanoh commented Oct 12, 2020

@Tenome no problem in the album in Japanese tracks, just change the line 177 json_select "English" to json_select "Japanese"

@romanoh
Copy link
Owner

romanoh commented Nov 3, 2020

@Tenome no problem in the album in Japanese tracks, just change the line 177 json_select "English" to json_select "Japanese"

This is no longer necessary as the script now pulls all the languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants