Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Please tag a new release and start using Semantic Versioning #7

Open
KateGo520 opened this issue Aug 7, 2020 · 3 comments

Comments

@KateGo520
Copy link

I found that this project already supports Go modules. The latest version v1.1.1 committed on 16 Jul 2018, and if module user run "go get gopkg.in/romanyx/recaptcha.v1", the old version v1.1.1 will be required.

$go get gopkg.in/romanyx/recaptcha.v1
go: downloading gopkg.in/romanyx/recaptcha.v1 v1.1.1
go: gopkg.in/romanyx/recaptcha.v1 upgrade => v1.1.1

So, I propose this project to tag a new release and follow Semantic Versioning. For example, v1.0.1, v2.0.0, v3.1.0-alpha, v3.1.0-beta.2etc, so that other project can use tag in go.mod.

@KateGo520
Copy link
Author

@lcd1232 Could you help me review this issue? Thx :p

@lcd1232
Copy link
Contributor

lcd1232 commented Sep 8, 2020

@KateGo520 how can I help you with?

@VadimKulagin
Copy link

Hello! I also noticed that in the last tag "v.1.1.2" there is an extra dot after the letter "v" which prevents a simple import of this version.

I solved this problem by importing with commit hash:

go get -v github.com/romanyx/recaptcha@23c4e60ed8eebe1e91393b4ea43d4fe1bf7e1da8

Which created the following line in go.mod:

github.com/romanyx/recaptcha v1.1.2-0.20180831135807-23c4e60ed8ee

But I want the package to have a normal tag.

And I think it's worth updating the package import path to github.com/romanyx/recaptcha instead of gopkg.in/romanyx/recaptcha.v1 in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants