Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC + Protocol Buffers #227

Closed
tiero opened this issue Mar 31, 2020 · 4 comments
Closed

gRPC + Protocol Buffers #227

tiero opened this issue Mar 31, 2020 · 4 comments

Comments

@tiero
Copy link

tiero commented Mar 31, 2020

On the line of this kyuupichan/electrumx#993 would you be interested in potential contributions to take full advantage of HTTP2 streaming features and self-generating stubs with grpc/protobuf ?
Thanks

@romanz
Copy link
Owner

romanz commented Apr 12, 2020

PRs are always welcome :)
If possible, please add a new binary target here:
https://github.com/romanz/electrs/tree/master/src/bin/

@tiero
Copy link
Author

tiero commented Apr 12, 2020

a new binary target here

Do you mean to specify multiple binaries, so it would be compiled to two different executables one with the JSONRPC and one with gRPC one?

Why not add in the same binary the gRPC interface exposed on a different port, where maybe the user could opt-in via a command?

@romanz
Copy link
Owner

romanz commented Apr 13, 2020

Why not add in the same binary the gRPC interface exposed on a different port, where maybe the user could opt-in via a command?

Sounds good.

@Kixunil
Copy link
Contributor

Kixunil commented Apr 13, 2020

Would be nice if it could work with both at the same time.

@romanz romanz closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants