Change how the signature base string is encoded per OAuth standards #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s (eg. asterisks) in services such as Instapaper fails by changing the way the signature base string is encoded.
ghost
assigned
romaonthego
added a commit
that referenced
this pull request
Mar 1, 2013
Change how the signature base string is encoded per OAuth standards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous method of encoding (adapted from AFHTTPClient's AFPercentEscapedQueryStringPairMemberFromStringWithEncoding) is not suitable for constructing a consistent base string to generate the signature from.
In particular, passwords with special symbols such as asterisks, and I believe square brackets and tilde will fail the signature match.
The final OAuth spec on percent encoding (http://tools.ietf.org/html/rfc5849#section-3.6) specifies that all unreserved character must not be encoded (per RFC 3986), while all other symbols must be encoded (which differs from RFC 3986).
In my tests following RFC 3986 by not encoding the unreserved characters seems to work fine.