🐛 On windows, glob pattern not working through package.json script (npm run command)

[himaanshu24]

Environment information

CLI:
  Version:              11.0.0
  Color support:        true Platform:
  CPU Architecture:     x86_64
  OS:                   windows Environment:
  ROME_LOG_DIR:         unset
  NO_COLOR:             unset
  TERM:                 "xterm-256color" Rome Configuration:
  Status:               loaded
  Formatter disabled:   false
  Linter disabled:      false Workspace:
  Open Documents:       0

What happened?

package.json file

"scripts": {
    "lint:js": "npx rome check cartridges/**/cartridge/client/**/js/"
}

Running npx rome check cartridges/**/cartridge/client/**/js/ works flawlessly on both platforms - Mac and Windows.
But when running npm run lint:js it is working on Mac but not on the windows machine, throwing the following error:

- The filename, directory name, or volume label syntax is incorrect. (os error 123)

The issue only happens when using the glob pattern, it works if used as follows:

"scripts": {
    "lint:js": "npx rome check cartridges/FOLDER_NAME/cartridge/client/SUBFOLDER_NAME/js/"
}

Expected result

The behavior should be consistent across the different platforms. Running the npm run command with the glob pattern should work on windows as well.

Thanks

Code of Conduct

• I agree to follow Rome's Code of Conduct

[himaanshu24]

@sebmck, don't we have the opposite of ignore (include) in the file object. This will give better flexibility in large and complex projects. It can have multiple patterns to traverse through, and the command can be only rome check

 "files": {
        "ignore": [
        ],
        "include": [ // proposed
        ],
    },

[ematipico]

Closing because we don't support glob patterns vi CLI yet