Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Code quality polish #936

Merged
merged 3 commits into from Aug 5, 2020
Merged

Code quality polish #936

merged 3 commits into from Aug 5, 2020

Conversation

sebmck
Copy link
Contributor

@sebmck sebmck commented Aug 5, 2020

Summary

This PR does the following:

  • Adds catch handlers to all uncaught and unhandled promises.
  • Turns some exceptions into fatal errors.
  • Adds private and public to all class properties and methods.
  • Removed a ton of dead code.

I did this all by hand. It was painful.

Test Plan

CI. Verify no snapshot changes.

@sebmck sebmck merged commit 9494b1b into main Aug 5, 2020
@sebmck sebmck deleted the sebmck/simplify branch August 5, 2020 07:32
@ematipico
Copy link
Contributor

Should we create a rule that enforces these keywords now? So we won't miss this in the future

@sebmck
Copy link
Contributor Author

sebmck commented Aug 5, 2020

I think we should, but I don't think we could have it enabled by default as this level of explicitness isn't usually necessary or the norm when writing TypeScript and would conflict with a lot of existing code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants