Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverting colors between buffers and tab numbers #57

Closed
Iron-E opened this issue Nov 14, 2020 · 2 comments · Fixed by #58
Closed

Inverting colors between buffers and tab numbers #57

Iron-E opened this issue Nov 14, 2020 · 2 comments · Fixed by #58
Assignees

Comments

@Iron-E
Copy link
Collaborator

Iron-E commented Nov 14, 2020

Oddity

The bar's background color also changes, from when there are only buffers (and no tabs open):

Original color

Is that intended?


Originally posted by @Iron-E in #22 (comment)

Making a new issue for this as requested. I currently have my eyes on this range as a potential problem area (although I don't really know for sure):

if layout.tabpages_width > 0 then
    result = result .. '%=%#BufferTabpages# ' .. tostring(current_tabpage) .. '/' .. tostring(total_tabpages) .. ' '
end

-- vim.g.layout = {
--   scroll = state.scroll,
--   max_scroll = max_scroll,
--   layout = layout,
--   needed_width = needed_width,
--   accumulated_width = accumulated_width,
-- }

result = result .. hl('TabLineFill')

I think this because when you change the %=% to something like %foo%, the bar comes back at the end:

Bar

I'm admittedly unfamiliar with tabline syntax though.

@romgrk
Copy link
Owner

romgrk commented Nov 14, 2020

%= is an alignment marker. What color do you want the filling to be? What's the output of hi BufferSignInactive?

@Iron-E
Copy link
Collaborator Author

Iron-E commented Nov 14, 2020

I'd like the filling to remain the same as when there is only one tab (and also when there are multiple tabs on HEAD~7), or be customizable.

The second screenshot shows this (don't mind the purple bar, that's i3wm):

Correct Color


When I run:

hi BufferSignInactive

it says the group hasn't been defined yet.

Edit: and if I link the group to Error (or something like that) nothing appears to change.


Edit 2: We got the name of the group wrong. Here's the output:

BufferInactiveSign xxx guifg=#505050 guibg=#505050

If I change that highlight group, this happens:

Screencap

Should we make another highlight group?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants