Leaderboard Setup project #1
Conversation
There was a problem hiding this comment.
Hi @rominana,
Good job so far!
Highlights!
- GitFlow ✔️
- No linter errors ✔️
- Descriptive pull request ✔️
- Descriptive commit messages ✔️
- Good code organization and working app ✔️
- Descriptive README ✔️
Hello ✋, you have done well reaching this point of the milestone 🤝 . But there are some issues that you still need to work on to go to the next project but you are almost there!
Status: Required Changes ♻️⛔️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread and tag me @julie-ify if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| <h1>Leaderboard</h1> | ||
| <div class="container"> | ||
| <section id="recent"> | ||
| <div class="head"> | ||
| <h2>Recent Scores</h2> | ||
| <button type="button" id="refresh">Refresh</button> | ||
| </div> | ||
| <ul id="leaderboard"> | ||
| <!-- Section generated using javascript--> | ||
| </ul> | ||
| </section> | ||
| <section id="add-section"> | ||
| <h2>Add your score</h2> | ||
| <input type="text" name="name" id="name" placeholder="Your name"> | ||
| <input type="text" name="score" id="score" placeholder="Your score"> | ||
| <button id="submit-score" type="button">Submit</button> | ||
| </section> | ||
| </div> |
There was a problem hiding this comment.
- Kindly match the wireframe provided for this project. The header should be placed to the left instead of in the middle. The Form button should look like the wireframe, and there should be space between the inputs. Kindly match the wireframe.
| Your Implementation | Wireframe |
|---|---|
 ) |
 |
|
All the required changes have been applied 😄 |
There was a problem hiding this comment.
STATUS: APPROVED 🟢
Hi @rominana👋,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
To Highlight 🎉
- No linter errors. ✔️
- Gitflow is followed. ✔️
- Professional README file. ✔️
- PR has a good title and summary. ✔️
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this project I: 🤓