Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboard: hit the API #2

Merged
merged 2 commits into from Jul 20, 2022
Merged

Leaderboard: hit the API #2

merged 2 commits into from Jul 20, 2022

Conversation

rominana
Copy link
Owner

In this project I: 😄

  • Created a new game called "Microverse Students Scores" using the provided API.
  • Implemented a "Refresh" button (receiving data from the API and parsing the JSON).
  • Implemented the form "Submit" button (sending data to the API).
  • Used arrow functions instead of the function keyword.
  • Used async and await JavaScript features to consume the API.

Copy link

@Reem-lab Reem-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rominana,👋🏻👋🏻

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉🔥🔥🔥

Highlights ✨✨

  • No Linters error ✅✅
  • Clean code ✅✅
  • Great working on the Functionality. ✅✅
  • Great following GitFlow ✅✅💪🏻💪🏻🔥🔥
  • Great using the async and await and arrow functions. ✅🔥

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@rominana rominana merged commit 421c7a6 into dev Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants