Added Unit/BoxedUnit serializers and tests #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default Fields serializer does not preserve the identity as it creates new object each time it is deserialized Thanks @aakoshh and @TimSoethout
|
It should be ready for 0.4.2 release. Do you want me to add also the README/version changes for the release? |
|
@luben Thanks, looks good! And yes, if you could prepare the README/version changes for the release, it would be nice. |
|
Updated the version. Please note that the README was also updated with information about the forthcoming 0.5.0 release based on Kryo-4.0 |
|
Thanks! Could you provide the release related changes in a separate PR? Let's not mix it with the code changes. I'm also not sure about the |
|
Done. Moved it to a separate PR for 0.4.2 release. I have also reverted the version.sbt as you suggested. I am preparing the changes and PR for 0.5.0 based on Kryo-4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It addresses #89