Further improvements to serialization #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 15, 2014 14:27
Couple of improvements to the serialization strategy: - emit the fact that the map is read-only, so we preserve that trait - write out the size and entries ourselves, not via an intermediate HashMap() The read path now takes these changes into account and resets the rootupdater after deserialization is done back to null. Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
Removes duplicate fields and makes the equivalent methods final. Also marks things that we take care of as transient, thus allowing us to reuse the JVM magic in serialization. Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
This was referenced Sep 15, 2014
romix
added a commit
that referenced
this pull request
Sep 15, 2014
Further improvements to serialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first patch eliminates the interim hashmap in the serialization path.
The second patch makes the equality/hash functions final and reworks the serialization path to use default java serializer as much as possible (which will set the final fields for us).