Rework read-only tracking #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 15, 2014 14:27
Couple of improvements to the serialization strategy: - emit the fact that the map is read-only, so we preserve that trait - write out the size and entries ourselves, not via an intermediate HashMap() The read path now takes these changes into account and resets the rootupdater after deserialization is done back to null. Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
Removes duplicate fields and makes the equivalent methods final. Also marks things that we take care of as transient, thus allowing us to reuse the JVM magic in serialization. Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
Instead of using the updater reference as the indicator of read-only views, add an explicit boolean. Thus all instances reuse a single updater reference, but still guard access to it via an explicit check. This changes the behavior a bit: instead of throwing NPE on read-only views, we throw IllegalStateException. The reason for that is that we should have caught the attempt in the MAP API functions. Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
|
With this merged, my queue is empty. Would it be possible to spin the 0.2.1 release? Can I help with anything to make that happen? |
|
I have released it as 0.2.23. It should arrive on Maven Central in a few hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of pull request #14, and changes how read-only is tracked. Instead of tracking a reference, there is final boolean field which is checked before the static updater is touched.
It should have the same (or slightly better) performance characteristics, that may or may not be true.