Use equal() instead of identity in readonly TNode #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rovarga
added a commit
to rovarga/scala
that referenced
this pull request
Nov 19, 2016
https://bugs.opendaylight.org/show_bug.cgi?id=6577 has uncovered an issue with a Java port of this implementation. OpenDaylight uses read-only snapshots to implement MVCC behavior and has the usage pattern of having multiple concurrent readers and a single writer. Under load with about 100K items in the map some 6 items fail to be found when we look at the read-only snapshot of state before deletion and look for items we know to have deleted. Additional investigation has shown that the items are present in the map with a non-identical, but equal key. Using entrySet() to locate the stored key and using that key for lookup results in the value being returned -- which is a violation of Map contract. This patch is a backport of romix/java-concurrent-hash-trie-map#24, which fixes the issue in the Java port. Signed-off-by: Robert Varga <nite@hq.sk>
Instead of requiring a match on identity, use equal() to compare the stored and lookup keys. This fixes https://bugs.opendaylight.org/show_bug.cgi?id=6577. This is a real bug coming from difference in operators between Java and Scala. Scala == boils down to .equals(), whereas in Java it is an identity check (eq in Scala). Signed-off-by: Robert Varga <nite@hq.sk>
|
@romix would you be so kind as to spin a new release with just this PR? |
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring a match on identity, use equal()
to compare the stored and lookup keys. This fixes
https://bugs.opendaylight.org/show_bug.cgi?id=6577.
Signed-off-by: Robert Varga nite@hq.sk