git prompt broken with some (multiline?) git config

[desbma]

When I add this in my git config (this is to configure the delta pager output, see chtenb/delta@603b807 for context):

[delta]
    minus-style = syntax "#330f0f"
    minus-emph-style = syntax "#4f1917"
    plus-style = syntax "#0e2f19"
    plus-emph-style = syntax "#174525"
    map-styles = \
       bold purple => syntax "#330f29", \
       bold blue => syntax "#271344", \
       bold cyan => syntax "#0d3531", \
       bold yellow => syntax "#222f14"
    zero-style = syntax
    whitespace-error-style = "#aaaaaa"

The git prompt does not show anymore. If I run killall gitstatusd it shows again, but will not on the next terminal.
If I has to guess I'd say gitstatusd fails to parse the multiline configuration entry.
Of course the git configuration is perfectly valid and git works as expected.

Thanks

[desbma]

If that helps, when I manually send a command to gitstatusd, it outputs this error:

ERROR src/repo_cache.cc:66] git_repository_open_ext: "[removed].git/": failed to parse config file: invalid configuration key (in /home/desbma/.config/git/config:49)

[romkatv]

This is probably an issue with libgit2. Can you check whether lg2 status works? You'll need to compile lg2 from sources. It's in examples, I think.

[desbma]

lg2 status works (libgit2 commit 416f7cb34762a75ae2ca14959caa59d94bc14919)

EDIT: Also works with libgit2 on tag v1.3.0

[desbma]

I'm using the Arch Linux package, which is using your libgit2 fork on the tag-d6c37a38587c9af2a9e63449fc8bf951dca0e854 tag, see https://github.com/archlinux/svntogit-community/blob/packages/zsh-theme-powerlevel10k/trunk/PKGBUILD#L9.
When building libgit2 on this commit, lg2 fails with failed to parse config file: invalid configuration key (in /home/desbma/.config/git/config:49

[romkatv]

Thanks for the details. So either there was a bug in libgit2 and it's got fixed (in which case I'll need to upgrade libgit2 dependency of gitstatusd) or I introduced a bug in my fork of libgit2 (in which case I would need to fix it).

I'm afraid I don't currently have time to do either for these. Maybe at some point in the future.

[desbma]

No worries I understand the lack of time.

The issue was not introduced by your fork, and with git bisect I found it was fixed upstream by this commit: 574c590f3095535e55e8f99b7f571ede28c8c211.

So just updating libgit2 should be enough to fix it.

[romkatv]

Thanks for doing all the work here. I've cherry-picked the commit you've identified and released a new version of gitstatusd. Please update powerlevel10k and let me know whether the issue is resolved.

[desbma]

It's fixed, thanks.

[romkatv]

Thanks for verifying.