Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Sorting ROMs by size doesn't work correctly for different units #627

Closed
zodac opened this issue Jan 21, 2024 · 3 comments
Closed

[Bug] Sorting ROMs by size doesn't work correctly for different units #627

zodac opened this issue Jan 21, 2024 · 3 comments
Assignees
@gantoine
Labels
bug Something isn't working

Comments

@zodac
Copy link

zodac commented Jan 21, 2024

RomM version
2.3.1

Describe the bug
Sorting ROMs by size doesn't consider MB/GB.

To Reproduce

  1. Open Gallary view for ROMs
  2. Have some ROMs with a size in MB, some with GB (or KB)

Expected behavior
ROMs with MB size to be sorted as smaller than ROMs with GB size

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows
  • Browser Chrome / Firefox
  • Version 120 / 121

Additional context
Similar to #423, possible regression?
@zodac zodac added the bug Something isn't working label Jan 21, 2024
@gantoine
Copy link
Member

This will be fixed in the upcoming 3.0 release.

@gantoine gantoine self-assigned this Jan 21, 2024
@zodac
Copy link
Author

zodac commented Jan 21, 2024

Awesome, thanks @gantoine !

@gantoine
Copy link
Member

Released and fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gantoine gantoine

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zodac @gantoine