Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Bug title #768

Closed
Bovive opened this issue Mar 28, 2024 · 4 comments
Closed

[Bug] Bug title #768

Bovive opened this issue Mar 28, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@Bovive
Copy link

Bovive commented Mar 28, 2024

RomM version
3.0.3

Describe the bug
The REDIS_PASSWORD environmental variable appears to no longer work. Unable to authenticate with a password enabled Redis server.

To Reproduce
Steps to reproduce the behavior:

  1. Password the Redis server.
  2. Enter the password as an environmental variable for ROMM.
  3. Receive error.

Expected behavior
Connect to Redis using a password.

Screenshots
None

Desktop (please complete the following information):

  • Unraid

Additional context
This is the log output for the error:

INFO: [RomM][2024-03-27 19:13:47] Connecting to redis... Traceback (most recent call last): File "/backend/watcher.py", line 9, in <module> from endpoints.sockets.scan import scan_platforms File "/backend/endpoints/sockets/scan.py", line 3, in <module> from endpoints.platform import PlatformSchema File "/backend/endpoints/platform.py", line 1, in <module> from decorators.auth import protected_route File "/backend/decorators/auth.py", line 7, in <module> from handler.auth_handler import DEFAULT_SCOPES_MAP, FULL_SCOPES_MAP, WRITE_SCOPES_MAP File "/backend/handler/__init__.py", line 18, in <module> igdb_handler = IGDBHandler() ^^^^^^^^^^^^^ File "/backend/handler/igdb_handler.py", line 155, in __init__ "Authorization": f"Bearer {self.twitch_auth.get_oauth_token()}", ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/backend/handler/igdb_handler.py", line 617, in get_oauth_token token = cache.get("romm:twitch_token") # type: ignore[attr-defined] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/backend/lib/python3.11/site-packages/redis/commands/core.py", line 1830, in get return self.execute_command("GET", name) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/backend/lib/python3.11/site-packages/redis/client.py", line 540, in execute_command conn = self.connection or pool.get_connection(command_name, **options) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/backend/lib/python3.11/site-packages/redis/connection.py", line 1104, in get_connection connection.connect() File "/backend/lib/python3.11/site-packages/redis/connection.py", line 288, in connect self.on_connect() File "/backend/lib/python3.11/site-packages/redis/connection.py", line 391, in on_connect self.read_response() File "/backend/lib/python3.11/site-packages/redis/connection.py", line 512, in read_response response = self._parser.read_response(disable_decoding=disable_decoding) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/backend/lib/python3.11/site-packages/redis/_parsers/resp2.py", line 15, in read_response result = self._read_response(disable_decoding=disable_decoding) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/backend/lib/python3.11/site-packages/redis/_parsers/resp2.py", line 38, in _read_response raise error redis.exceptions.AuthenticationError: Authentication required.

@Bovive Bovive added the bug Something isn't working label Mar 28, 2024
@gantoine
Copy link
Member

gantoine commented Mar 28, 2024

We built redis into the image in 3.0, but we'll be bringing back the option to run it outside romm in 3.1. Upgrade to it once it (or the first release candidate) is released, and the redis connection should start working again.

@Bovive
Copy link
Author

Bovive commented Mar 28, 2024

We built redis into the image in 3.0, but we'll be bringing back the option to run it outside romm in 3.1. Upgrade to it once it (or the first release candidate) is released, and the redis connection should start working again.

The release notes for 3.0.2 say that external Redis support was added back in that release.

@gantoine
Copy link
Member

Sorry I should have clarified, 3.0.3 brought back redis host and port, but we forgot password. It will release with the 3.1 RC.1.

@Bovive
Copy link
Author

Bovive commented Mar 28, 2024

Gotcha, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants