-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Copy download link doesn't work #818
Comments
To be honest I only tested it in Firefox. Could you test with firefox and post the results? I'll test myself in chrome and edge of course |
I had to switch PC, now I'm on Windows 11 and with Firefox (fresh installation) I still can't copy the download link. Here's the console error message: EDIT: surfing StackOverflow I might have found what's causing the issue: https://stackoverflow.com/questions/51805395/navigator-clipboard-is-undefined |
lmaooooo i can't believe i didn't see this in the PR 🤦🏼 @zurdi15 you used to be able to use |
wow how is this possible? how could I use In any case I like the google photos approach, if that method is not available we show a popup with the link to copy it manually |
yes something like that!
makes sense to me, assigning this to you and backlogging it |
This will be available in the next release (3.2.0). |
RomM version
RomM 3.1.0-rc.3
Describe the bug
When clicking the copy download link button, nothing happens.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
When clicking the copy button, the download link should be copied to the clipboard. Even better, a small toast with "Download link copied to the clipboard" should be displayed to the user.
Screenshots
![image](https://private-user-images.githubusercontent.com/7896815/323644931-9928147a-2325-42cb-8597-04ca556ba4bb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI4MDQxOTIsIm5iZiI6MTcyMjgwMzg5MiwicGF0aCI6Ii83ODk2ODE1LzMyMzY0NDkzMS05OTI4MTQ3YS0yMzI1LTQyY2ItODU5Ny0wNGNhNTU2YmE0YmIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDRUMjAzODEyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZTJmYmI0Y2ViNmVkNDllYzM1OGU1NWRmNDUxZTdjNTBjZjg3YTY2OTllNjQ3ZmUxMjhiMjgxOTI3NmExZjIxMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.S4DLslk8Cl0sfYkK127XFMdRI8t3jypcML3HMhJ7Gcc)
Desktop:
Additional context
Also tried with Microsoft Edge, can reproduce the issue. Tried with single file ROMs games (eg. NES) and multi file ROMs (eg. PS1) and both produces the same issue.
The text was updated successfully, but these errors were encountered: