Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended/ID search not working #866

Closed
Dreadlocke12 opened this issue May 22, 2024 · 2 comments
Closed

Extended/ID search not working #866

Dreadlocke12 opened this issue May 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Dreadlocke12
Copy link

RomM version
3.1.0

Describe the bug
I have the plattform pico-8 created for pico-8 games but when i search for artwork over igdb I can not find it. I know the game exists in the database but is not related to a plattform. The URL is https://www.igdb.com/games/netty so basically this is part of the IGDB games folder. Searching using the ID is not working as well. The same behaviour goes for other platforms which are also listed in IGDB. It seems if it is not related directly to the platform in IGDB finding it is not possible.

To Reproduce
Steps to reproduce the behavior:

  1. Manual Search
  2. Search by name or search by ID
  3. Error sign without text appears

Expected behavior
No suggestions are provided

Screenshots
Screenshot 2024-05-22 at 10 04 23
Screenshot 2024-05-22 at 10 04 19
Screenshot 2024-05-22 at 10 04 04

Desktop (please complete the following information):

  • tested on macOS, Linux
  • Browser: Chrome, Firefox
  • Version (Chrome): Version 124.0.6367.208

Smartphone (please complete the following information):

  • Device: Fairphone 4
  • OS: Android 13
  • Browser Firefox
  • Version: 126.0
@Dreadlocke12 Dreadlocke12 added the bug Something isn't working label May 22, 2024
@Tom-Welch
Copy link

I've also been trying to search by ID as I know the game exists on IGDB. Here's a couple of things i've found whilst digging.

My log file is showing a dictionary key error. /backend/endpoints/search.py Line 81.

Excuse my limited experience, but it appears as if even with the Moby Games provider disabled, the moby_matched_roms variable is still being looped over to merge the dicts which is throwing the key error as it's empty.

@gantoine
Copy link
Member

Duplicate of #838, fix is here 👉🏼 #863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants