Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create init for error receiving an Error + Remove unknown error #15

Merged
merged 5 commits into from
Jan 13, 2018

Conversation

ronanrodrigo
Copy link
Owner

Created an init for FrisbeError and remove some error handling in NetworkGet. With that is more easy to test error handling and .unknown error is unnecessary.

@codecov-io
Copy link

codecov-io commented Jan 12, 2018

Codecov Report

Merging #15 into master will increase coverage by 2.49%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   95.03%   97.53%   +2.49%     
==========================================
  Files           8       12       +4     
  Lines         141      162      +21     
  Branches       11       11              
==========================================
+ Hits          134      158      +24     
+ Misses          7        4       -3
Impacted Files Coverage Δ
...ces/Frisbee/Factories/ResultGeneratorFactory.swift 100% <100%> (ø)
Sources/Frisbee/Requestables/NetworkGet.swift 100% <100%> (+7.31%) ⬆️
...rces/Frisbee/Interactors/URLWithQueryBuilder.swift 86.66% <100%> (ø) ⬆️
Sources/Frisbee/Entities/FrisbeeError.swift 100% <100%> (ø) ⬆️
Sources/Frisbee/Entities/FrisbeeJSONDecoder.swift 100% <100%> (ø)
...es/Frisbee/Factories/FrisbeeDecodableFacotry.swift 100% <100%> (ø)
...isbee/Factories/URLWithQueryBuildableFactory.swift 100% <100%> (ø)
Sources/Frisbee/Interactors/ResultGenerator.swift 100% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb39546...7b29d05. Read the comment docs.

@ronanrodrigo ronanrodrigo merged commit 2de7293 into master Jan 13, 2018
@ronanrodrigo ronanrodrigo deleted the hotfix/frisbee-error branch January 13, 2018 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants