Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON (de/en)coder to Adapter's initializers #23

Merged
merged 1 commit into from
Jan 21, 2018

Conversation

williamhjcho
Copy link
Collaborator

JSON (de/en)coders can be configured with some other options, this just allows them to be inserted before initializing the adapters

More work should be done on whoever uses them

@codecov-io
Copy link

codecov-io commented Jan 21, 2018

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #23   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines         242    248    +6     
  Branches       17     17           
=====================================
+ Hits          242    248    +6
Impacted Files Coverage Δ
Sources/Frisbee/Adapters/EncoderJSONAdapter.swift 100% <100%> (ø) ⬆️
Sources/Frisbee/Adapters/DecoderJSONAdapter.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56fca8...87d0b27. Read the comment docs.

Copy link
Owner

@ronanrodrigo ronanrodrigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ronanrodrigo ronanrodrigo merged commit e7f9b64 into master Jan 21, 2018
@ronanrodrigo ronanrodrigo deleted the add-json-coding-initializers branch January 21, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants