Add URL arguments on get methods #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
==========================================
- Coverage 94.04% 92.78% -1.27%
==========================================
Files 6 6
Lines 84 97 +13
Branches 7 8 +1
==========================================
+ Hits 79 90 +11
- Misses 5 7 +2
Continue to review full report at Codecov.
|
williamhjcho
force-pushed
the
add-url-arguments
branch
3 times, most recently
from
1b15ebd
to
d0d98a2
Compare
ronanrodrigo
reviewed
Jan 6, 2018
| public func get<Entity: Decodable, Query: Encodable>(url: String, query: Query, | ||
| onComplete: @escaping (Result<Entity>) -> Void) { | ||
| guard let url = URL(string: url) else { | ||
| return |
There was a problem hiding this comment.
Is necessary to call onComplete with fail and FrisbeeError.invalidUrl error.
williamhjcho
force-pushed
the
add-url-arguments
branch
from
d0d98a2
to
f16fc2e
Compare
The String argument overloads should prefer URL overloads since they are already converted and ready for use
williamhjcho
force-pushed
the
add-url-arguments
branch
from
f16fc2e
to
85036c7
Compare
|
Thank you @william-wc it was very good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
URLto be build beforehand by someone elseThe
Stringargument overloads should prefer/useURLoverloads since they are already converted and ready for use