Equatables for Result and FrisbeeError #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
==========================================
+ Coverage 92.78% 95.03% +2.25%
==========================================
Files 6 8 +2
Lines 97 141 +44
Branches 8 11 +3
==========================================
+ Hits 90 134 +44
Misses 7 7
Continue to review full report at Codecov.
|
|
These equatables are just use in test target. Do you think it is necessary to move them to production target? |
|
Makes it easier for the future, there is also no need for them to not be |
williamhjcho
force-pushed
the
equatables
branch
from
2ffcbb1
to
6b98f77
Compare
…uatable Add extensiveCombine on TestTarget to enable cartesian product of Sequences
williamhjcho
force-pushed
the
equatables
branch
from
6b98f77
to
ccfa5a9
Compare
ronanrodrigo
reviewed
Jan 7, 2018
| } | ||
|
|
||
| extension FrisbeeError { | ||
| static func all(error: Error) -> [FrisbeeError] { |
There was a problem hiding this comment.
To simplify this function, maybe error could be just some string. And maybe SomeError doesn't need to exist 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equatableextensions from tests to frameworkResultget-propertiesextensions to frameworkFrisbeeError: Equatable==overload whenEntity: EquatableonResultSequence.extensiveCombineon testing target to enable cartesian product ofSequences[0,1] x [a, b, c] = [(0,a), (0,b), (0,c), (1,a), (1,b), (1,c)]