Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<support/musl/xlocale.h> doesn't always get included? #5

Open
ronchaine opened this issue Mar 15, 2020 · 1 comment
Open

<support/musl/xlocale.h> doesn't always get included? #5

ronchaine opened this issue Mar 15, 2020 · 1 comment
Labels
bug Something isn't working clang Concerns clang component has workaround We can work around this, but it's not solved

Comments

@ronchaine
Copy link
Owner

ronchaine commented Mar 15, 2020

Taking <support/musl/xlocale.h> out of #ifdefs (copypasting it after the next #endif), everything compiles fine. Which doesn't make sense, since putting a #warning inside the ifdef branch where the include is still shows.

@ronchaine ronchaine added the clang Concerns clang component label Mar 15, 2020
@ronchaine ronchaine changed the title <support/musl/xlocale.h> doesn't always get included? <support/musl/xlocale.h> doesn't always get included? Mar 15, 2020
@ronchaine
Copy link
Owner Author

Offending files:

libcxx/src/iostream.cpp
libcxx/src/locale.cpp
libcxx/src/random.cpp
libcxx/src/atomic.cpp
libcxx/src/algorithm.cpp
libcxx/src/strstream.cpp
libcxx/src/ios.cpp
libcxx/src/filesystem/directory_iterator.cpp
libcxx/src/filesystem/operations.cpp

All of these seem to include ostream

@ronchaine ronchaine added has workaround We can work around this, but it's not solved bug Something isn't working labels Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working clang Concerns clang component has workaround We can work around this, but it's not solved
Projects
None yet
Development

No branches or pull requests

1 participant