Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium browser_type is unknown on Windows #31

Closed
SergeyPirogov opened this issue Jul 11, 2022 · 1 comment · Fixed by #32
Closed

Chromium browser_type is unknown on Windows #31

SergeyPirogov opened this issue Jul 11, 2022 · 1 comment · Fixed by #32
Assignees
Labels
bug Something isn't working

Comments

@SergeyPirogov
Copy link

Hello, I see that Chromium browser_type is unknown on Windows

{'browser_type': 'unknown',
  'display_name': 'Chromium',
  'path': 'C:\\Program Files\\Chromium\\Application\\chrome.exe',
  'version': '103.0.5060.114'},
@roniemartinez
Copy link
Owner

Thanks @SergeyPirogov good spot.

It looks like Chromium is missing from this dictionary. Do you want to make a PR?

WINDOWS_REGISTRY_BROWSER_NAMES = {
"Google Chrome": "chrome",
"Google Chrome Canary": "chrome-canary",
"Mozilla Firefox": "firefox",
"Firefox Developer Edition": "firefox-developer",
"Firefox Nightly": "firefox-nightly",
"Opera Stable": "opera",
"Opera beta": "opera-beta",
"Opera developer": "opera-developer",
"Microsoft Edge": "msedge",
"Microsoft Edge Beta": "msedge-beta",
"Microsoft Edge Dev": "msedge-dev",
"Microsoft Edge Canary": "msedge-canary",
"Internet Explorer": "msie",
"Brave": "brave",
"Brave Beta": "brave-beta",
"Brave Nightly": "brave-nightly",
}

@roniemartinez roniemartinez added the bug Something isn't working label Jul 11, 2022
@roniemartinez roniemartinez self-assigned this Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants