-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In Android not able to read Arabic translation JSON file using JSONStream #51
Comments
Could you please provide a sample json that is problematic? |
@RonRadtke
This is added to a json file in android document directory and tried to read using JSONStream. done or fail block not getting called. If I removed this Arabic text from the json the JSONStream is calling the done block. |
@RonRadtke I have fixed the issue in this PR, #53 |
Thank you for your PR. Also I don't like to have different handling for the different encodings. If we go for it, it would be better to ignore the encoding errors for all different types of encoding to have a similar behavior all over the code. |
Hello! I completely understand your comments, in fact I would say the same thing. That being said, is there any chance we can have a beta version with this quick fix until you can fix the actual problem? I'd really rather not fork this repo (yet again) and re-host just to have a temporary fix, and I don't have the time to invest in exploring other avenues for a fix. |
I pushed your fix on a feature branch. Due to the merge conflict I just copied it quickly. So you should be able to install it by running |
Wonderful! Thank you so much, this is going to save us a lot of trouble! |
I'm relatively sure I know the cause of the problem now.
I assume your file is fine, otherwise you would most likely have problems in iOS too. I would like to ask you to test the changes with your file to verify it's working fine - I hope you could help there @devinm-hrbl / @midhunm-c ? |
Thank you very much @RonRadtke !! |
|
@midhunm-c branch is ready for you. |
Thank you @RonRadtke !! |
Glad to hear :) |
@devinm-hrbl I published a new version including the fix. |
Hi @RonRadtke thank you for the new release :)
PS: |
Yeah you're right - I messed that one up when fixing the import cycles. |
Thank you @RonRadtke !! |
Good - then I close the issue and delete the branch within the next days :) |
Thank you so much @RonRadtke , and great collaboration @midhunm-c! |
Arabic translation JSON file is downloaded to document directory and it is reading and parsing using RNFetchBlob.JSONStream.
Issue:
In android when we tried to read Arabic translation file using JSONStream the callbacks done or fail in not getting called. And not throwing any exceptions.
In iOS JSONStream is calling done block once the same Arabic json file read complete.
Please note: I have checked this with
joltup/rn-fetch-blob
but I also tried to install the latest version of this library, and the result is same.
The text was updated successfully, but these errors were encountered: