operator: move most of discover pod setting to cm #12691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
reviewed
Aug 9, 2023
subhamkrai
force-pushed
the
operator-placement
branch
2 times, most recently
from
27026ae
to
7385048
Compare
subhamkrai
changed the title
subhamkrai
force-pushed
the
operator-placement
branch
from
7385048
to
f36d038
Compare
|
Tested with few settings # added toleration from
023-08-16 08:46:09.325812 I | op-k8sutil: DISCOVER_TOLERATIONS="- effect: NoSchedule\n key: hostname\n operator: Equal\n value: minikube\n" (configmap)
2023-08-16 08:46:09.325921 I | op-discover: tolerations: [{hostname Equal minikube NoSchedule <nil>}]# Also, disabled discover pod from cm
2023-08-16 09:26:43.744031 I | op-k8sutil: ROOK_ENABLE_DISCOVERY_DAEMON="false" (configmap) |
subhamkrai
force-pushed
the
operator-placement
branch
from
f36d038
to
79f8841
Compare
subhamkrai
commented
Aug 16, 2023
There was a problem hiding this comment.
@travisn do I need to modify settings for helm chart also,? currently, I don't see discover pod settings in helm settings so I have not added yet.
The helm settings for discovery settings are in the helm chart, just in the env vars. We can leave them in the env vars too for now in the helm chart. |
travisn
reviewed
Aug 16, 2023
subhamkrai
force-pushed
the
operator-placement
branch
from
79f8841
to
6748ccf
Compare
travisn
requested changes
Aug 16, 2023
It's better to move most of discover daemon setting from env to configmap rook-ceph-operator-config. Although, we are moving to configmap, we keep reading settings from env but the priority will be configmap settings. Signed-off-by: subhamkrai <srai@redhat.com>
subhamkrai
force-pushed
the
operator-placement
branch
from
6748ccf
to
fb39580
Compare
travisn
approved these changes
Aug 16, 2023
travisn
added a commit
that referenced
this pull request
Sep 7, 2023
operator: move most of discover pod setting to cm (backport #12691)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
operator: move most of discover pod setting to cm
It's better to move most of discover daemon setting
from env to configmap rook-ceph-operator-config.
Which issue is resolved by this Pull Request:
Resolves #12651
Checklist:
skip-cion the PR.