monitoring: add "for" to CephOSDDownHigh alert #12731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of a normal restart, an OSD can go down just as prometheus tries to scrape it, causing this alert to fire. Alerts shouldn't fire as part of normal operations. This change requires the OSD to be down for 5 consecutive minutes before the alert will fire. Signed-off-by: Chris Jones <chris@cjones.org>
parth-gr
reviewed
Aug 16, 2023
| @@ -89,6 +89,7 @@ groups: | |||
| description: "{{ $value | humanize }}% or {{ with query \"count(ceph_osd_up == 0)\" }}{{ . | first | value }}{{ end }} of {{ with query \"count(ceph_osd_up)\" }}{{ . | first | value }}{{ end }} OSDs are down (>= 10%). The following OSDs are down: {{- range query \"(ceph_osd_up * on(ceph_daemon) group_left(hostname) ceph_osd_metadata) == 0\" }} - {{ .Labels.ceph_daemon }} on {{ .Labels.hostname }} {{- end }}" | |||
| summary: "More than 10% of OSDs are down" | |||
| expr: "count(ceph_osd_up == 0) / count(ceph_osd_up) * 100 >= 10" | |||
| for: "5m" | |||
There was a problem hiding this comment.
any specific reason for choosing 5m?
There was a problem hiding this comment.
Not really. It's a constant that appears other places in this file. It should be longer than the expected time for the old OSD pod to terminate plus the time for the new OSD pod to become ready, in a healthy Kubernetes cluster.
There was a problem hiding this comment.
I see most of the other alerts have the same 5m time, so this seems reasonable.
travisn
approved these changes
Aug 16, 2023
| @@ -89,6 +89,7 @@ groups: | |||
| description: "{{ $value | humanize }}% or {{ with query \"count(ceph_osd_up == 0)\" }}{{ . | first | value }}{{ end }} of {{ with query \"count(ceph_osd_up)\" }}{{ . | first | value }}{{ end }} OSDs are down (>= 10%). The following OSDs are down: {{- range query \"(ceph_osd_up * on(ceph_daemon) group_left(hostname) ceph_osd_metadata) == 0\" }} - {{ .Labels.ceph_daemon }} on {{ .Labels.hostname }} {{- end }}" | |||
| summary: "More than 10% of OSDs are down" | |||
| expr: "count(ceph_osd_up == 0) / count(ceph_osd_up) * 100 >= 10" | |||
| for: "5m" | |||
There was a problem hiding this comment.
I see most of the other alerts have the same 5m time, so this seems reasonable.
travisn
added a commit
that referenced
this pull request
Aug 16, 2023
monitoring: add "for" to CephOSDDownHigh alert (backport #12731)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of a normal restart, an OSD can go down just as prometheus tries to scrape it, causing this alert to fire. Alerts shouldn't fire as part of normal operations. This change requires the OSD to be down for 5 consecutive minutes before the alert will fire.
Checklist:
skip-cion the PR.