build: update go version to 1.21 from 1.20 #12788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parth-gr
approved these changes
Aug 24, 2023
parth-gr
reviewed
Aug 24, 2023
subhamkrai
force-pushed
the
update-go-1.21.0
branch
from
209709d
to
8822fa8
Compare
travisn
requested changes
Aug 24, 2023
go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/rook/rook | |||
|
|
|||
| go 1.20 | |||
| go 1.21 | |||
There was a problem hiding this comment.
I don't think we can update this until we drop 1.20 support.
There was a problem hiding this comment.
I think an earlier upgrade is better for us, or sometime soon some cve will be open to fix the golang version, do we need to wait for something before upgrading?
There was a problem hiding this comment.
It's good to support the most recent two versions of golang for a while so we can have some overlap to give devs and dependent CI systems time to update. Go 1.20 should still get CVE fixes for a while too.
subhamkrai
force-pushed
the
update-go-1.21.0
branch
from
8822fa8
to
5c5e2da
Compare
Signed-off-by: subhamkrai <srai@redhat.com>
subhamkrai
force-pushed
the
update-go-1.21.0
branch
from
5c5e2da
to
e9cc7ed
Compare
travisn
approved these changes
Aug 25, 2023
travisn
added a commit
that referenced
this pull request
Aug 28, 2023
build: update go version to 1.21 from 1.20 (backport #12788)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
skip-cion the PR.